✨ Pass-through timeout options to net-ldap #106
Merged
+48
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 97.33% 96.79% -0.54%
==========================================
Files 4 4
Lines 300 312 +12
Branches 106 116 +10
==========================================
+ Hits 292 302 +10
- Misses 8 10 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds timeout configuration support for LDAP connections by introducing connect_timeout and read_timeout options that are forwarded to the underlying Net::LDAP connection.
Key changes:
- Added timeout configuration options (
connect_timeoutandread_timeout) to the strategy and adaptor - Implemented backward-compatible timeout setting logic that uses setters if available, otherwise falls back to instance variable assignment
- Added test coverage for timeout configuration behavior
- Updated documentation with examples and descriptions of the new timeout options
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| lib/omniauth/strategies/ldap.rb | Adds connect_timeout and read_timeout strategy options |
| lib/omniauth-ldap/adaptor.rb | Implements timeout setting logic with backward compatibility for older net-ldap versions |
| spec/omniauth-ldap/adaptor_spec.rb | Adds test coverage for timeout configuration scenarios |
| README.md | Documents the new timeout options with examples and fixes link references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- connect_timeout - read_timeout
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements and closes #63